[GWC-1344] Hide version info on embedded GWC home page #1345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 14, 2025
aaime
reviewed
Jan 20, 2025
| @@ -73,6 +73,14 @@ public void checkSecurity(TileLayer layer, @Nullable BoundingBox extent, @Nullab | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
As far as I know, if GWC is deployed stand-alone, there are indeed no SecurityFilter, the only implementation I'm aware of is in GeoServer (which you have updated accordingly in the GS counterpart).
I'm asking because I don't want to give the wrong impression in the GWC release notes... the commit message should probably be something along the lines of "Support hiding GWC version when integrated in GeoServer".
(we use the commit messages to build the GWC release notes)
|
@aaime I have addressed your commit message feedback by "embedded GWC" to imply in GeoServer only. |
aaime
changed the title
jodygarnett
pushed a commit
to jodygarnett/geowebcache
that referenced
this pull request
Jan 24, 2025
jodygarnett
pushed a commit
to jodygarnett/geowebcache
that referenced
this pull request
Jan 24, 2025
jodygarnett
pushed a commit
that referenced
this pull request
Jan 24, 2025
# Conflicts: # geowebcache/core/src/main/java/org/geowebcache/GeoWebCacheDispatcher.java
jodygarnett
pushed a commit
that referenced
this pull request
Jan 24, 2025
# Conflicts: # geowebcache/core/src/main/java/org/geowebcache/GeoWebCacheDispatcher.java # Conflicts: # geowebcache/core/src/test/java/org/geowebcache/GeoWebCacheDispatcherTest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR hides version information and some other internal server information from the GeoServer embedded GeoWebCache home page unless the user is logged in as an administrator.
The version number is still visible in a stand-alone GWC
Issue: #1344