-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fixes #12862] Allow to add metadata when uploading a resource #12874
base: master
Are you sure you want to change the base?
[Fixes #12862] Allow to add metadata when uploading a resource #12874
Conversation
cfcd549
to
b28b8cb
Compare
b28b8cb
to
d1957c9
Compare
@mattiagiupponi not sure if you had a look already .. but I saw this issues which seems to be related to this one and already got merged. |
Hi @ridoo |
No problem at all. Thanks for the info. Have a nice weekend! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HI @ridoo
Overall looks good, can you please add a couple of tests?
- a smoke test for the new storer (like it was done here for the region one)
- A test where the upload workflow works as expected and the metadata are updated
f520d03
to
b23e60d
Compare
@mattiagiupponi locally my tests run fine 🤔 Do you have an idea? To be honest, I have some troubles running your really complex test suite. What I am doing is just skipping the |
[Currently work in progress]
Reads and passes
custom
json payload during upload to be set on the new geonode resource. Should work also for resources which shall be overridden.This PR contains some fixes/changes of seemingly unrelated parts where errors occured during testing. The proposed changes have to be reviewed and discussed first. Chances are that I missed important parts. However, this PR reveals those locations better than my comment on the related issue.
Referenced ticket: #12862
Checklist
For all pull requests:
The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):
Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.