Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #12858] Fixed missing translations for facets labels #12859

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

giohappy
Copy link
Contributor

@giohappy giohappy commented Jan 28, 2025

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Jan 28, 2025
@giohappy giohappy requested a review from etj January 28, 2025 17:04
@giohappy giohappy self-assigned this Jan 28, 2025
@giohappy giohappy modified the milestone: 4.4.2 Jan 28, 2025
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.97%. Comparing base (5eaad8a) to head (5afc71b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #12859   +/-   ##
=======================================
  Coverage   67.97%   67.97%           
=======================================
  Files         977      977           
  Lines       59040    59045    +5     
  Branches     6897     6897           
=======================================
+ Hits        40132    40137    +5     
  Misses      17266    17266           
  Partials     1642     1642           

@giohappy giohappy linked an issue Jan 28, 2025 that may be closed by this pull request
@giohappy giohappy merged commit 6bc698f into master Jan 28, 2025
19 checks passed
@giohappy giohappy deleted the issue_12858 branch January 28, 2025 17:44
github-actions bot pushed a commit that referenced this pull request Jan 28, 2025
giohappy added a commit that referenced this pull request Jan 28, 2025
(cherry picked from commit 6bc698f)

Co-authored-by: Giovanni Allegri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 4.4.x cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some labels for the facets are not translated
2 participants