Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: get_genomic_mane_genes should return mane status #398

Merged
merged 3 commits into from
Feb 12, 2025
Merged

feat!: get_genomic_mane_genes should return mane status #398

merged 3 commits into from
Feb 12, 2025

Conversation

korikuzma
Copy link
Member

No description provided.

@korikuzma korikuzma added enhancement New feature or request priority:high High priority labels Feb 11, 2025
@korikuzma korikuzma requested a review from katiestahl February 11, 2025 21:53
@korikuzma korikuzma self-assigned this Feb 11, 2025
katiestahl
katiestahl previously approved these changes Feb 11, 2025
View reviewed changes
src/cool_seq_tool/sources/mane_transcript_mappings.py

if len(mane_rows) == 0:
if mane_rows.is_empty():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any case where mane_rows could be None? I think that may cause an exception here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/GenomicMedLab/cool-seq-tool/blob/add-mane-status/tests/sources/test_mane_transcript_mappings.py#L261

@korikuzma korikuzma requested a review from katiestahl February 11, 2025 22:00
katiestahl
katiestahl approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@katiestahl katiestahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@korikuzma korikuzma merged commit de3d5c0 into main Feb 12, 2025
12 checks passed
@korikuzma korikuzma deleted the add-mane-status branch February 12, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katiestahl katiestahl katiestahl approved these changes

Assignees

@korikuzma korikuzma

Labels
enhancement New feature or request priority:high High priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@korikuzma @katiestahl