Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: collect all pango lineage values and output them #7

Merged
merged 3 commits into from
Nov 5, 2024

Conversation

fengelniederhammer
Copy link
Contributor

resolves #6

@fengelniederhammer fengelniederhammer force-pushed the 6-collect-all-pango-lineages branch from d0ea26a to 946408a Compare October 30, 2024 16:19
so that old processed data versions are easier to delete
(You just delete that directory instead of searching for files with a certain version)
@fengelniederhammer fengelniederhammer force-pushed the 6-collect-all-pango-lineages branch from dbab5ad to e68ae27 Compare October 31, 2024 10:30
@fengelniederhammer fengelniederhammer marked this pull request as ready for review November 4, 2024 08:19
Copy link
Contributor

@JonasKellerer JonasKellerer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I find it hard to follow, where which data is during the ingest. It would be nice to have some sort of documentation in the README.

@fengelniederhammer
Copy link
Contributor Author

Proper docs would be nice indeed, but it's probably out of scope for this package...

@fengelniederhammer fengelniederhammer merged commit cb4837c into main Nov 5, 2024
1 check passed
@fengelniederhammer fengelniederhammer deleted the 6-collect-all-pango-lineages branch November 5, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collect all pango lineages
2 participants