Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and improve SARS-CoV-2 open pipeline #5

Merged
merged 2 commits into from
May 14, 2024
Merged

Fix and improve SARS-CoV-2 open pipeline #5

merged 2 commits into from
May 14, 2024

Conversation

chaoran-chen
Copy link
Member

  • The final output is now moved to the 00_archive folder.
  • A bug when downloading open data was fixed.

import org.genspectrum.ingest.proc.transformSC2GisaidBasics
import org.genspectrum.ingest.proc.tsvToNdjson
import org.genspectrum.ingest.proc.unalignedNucleotideSequencesToFasta
import org.genspectrum.ingest.proc.*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's usually better to avoid wildcard imports (in the worst case you end up using a different class of the same name without noticing).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I need to configure IntelliJ properly.. I just fixed it.

@chaoran-chen chaoran-chen merged commit f9fdfaa into main May 14, 2024
1 check passed
@chaoran-chen chaoran-chen deleted the sc2-open branch May 14, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants