-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alternative_grid_size #692
Conversation
…ter-mutations-over-time
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This is a preview of the changelog of the next release. If this branch is not up-to-date with the current main branch, the changelog may not be accurate. Rebase your branch on the main branch to get the most accurate changelog. Note that this might contain changes that are on main, but not yet released. Changelog: 0.13.5 (2025-01-24)Features |
Could you please squash and make it a PR to main? It's hard to review when it's actually two stacked PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the demo, in case of problems we can always revert I suppose?
/** | ||
* The maximum number of grid rows to display. | ||
* | ||
* Visit https://genspectrum.github.io/dashboard-components/?path=/docs/components-size-of-components--docs for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please at least issue a follow up PR to get rid of this?
(And add the new attribute to the web component storybook - both the args and the code example in the docs)
resolves #
Summary
Screenshot
confirmed this also works with a dashboards change
PR Checklist