Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative_grid_size #692

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Alternative_grid_size #692

merged 2 commits into from
Jan 24, 2025

Conversation

anna-parker
Copy link
Collaborator

@anna-parker anna-parker commented Jan 24, 2025

resolves #

Summary

Screenshot

confirmed this also works with a dashboards change

PR Checklist

  • All necessary documentation has been adapted.
  • The implemented feature is covered by an appropriate test.

Copy link

vercel bot commented Jan 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 1:11pm

Copy link
Contributor

This is a preview of the changelog of the next release. If this branch is not up-to-date with the current main branch, the changelog may not be accurate. Rebase your branch on the main branch to get the most accurate changelog.

Note that this might contain changes that are on main, but not yet released.

Changelog:

0.13.5 (2025-01-24)

Features

  • components: let maxNumberOfGridRows be configurable for wastewater-mutations-over-time (199cea3)
  • components: wastewater-mutations-over-time - always show all mutations in grid (2dd03dc)

@fengelniederhammer
Copy link
Collaborator

Could you please squash and make it a PR to main? It's hard to review when it's actually two stacked PRs.

Copy link

@Taepper Taepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the demo, in case of problems we can always revert I suppose?

@anna-parker anna-parker merged commit 768dc3a into main Jan 24, 2025
8 checks passed
@anna-parker anna-parker deleted the alternative_grid_size branch January 24, 2025 13:38
/**
* The maximum number of grid rows to display.
*
* Visit https://genspectrum.github.io/dashboard-components/?path=/docs/components-size-of-components--docs for more information.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please at least issue a follow up PR to get rid of this?

(And add the new attribute to the web component storybook - both the args and the code example in the docs)

@fengelniederhammer fengelniederhammer mentioned this pull request Jan 27, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants