Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): remove headline from all visualization components #352

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

fengelniederhammer
Copy link
Collaborator

resolves #350

Summary

(See issue)

Screenshot

PR Checklist

  • All necessary documentation has been adapted.
  • The implemented feature is covered by an appropriate test.

Sorry, something went wrong.

Copy link

vercel bot commented Jul 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2024 0:23am

Copy link
Contributor

github-actions bot commented Jul 17, 2024

This is a preview of the changelog of the next release:

0.6.0 (2024-07-17)

⚠ BREAKING CHANGES

  • components: remove the headline attribute from all visualization components. Instead, dashboard developers should simply create a headline themselves, outside the component, using standard HTML/CSS.

Features

  • components: remove headline from all visualization components (77bac6a), closes #350

BREAKING CHANGE: remove the `headline` attribute from all visualization components.
Instead, dashboard developers should simply create a headline themselves, outside the component,
using standard HTML/CSS.

closes #350
Copy link
Collaborator

@JonasKellerer JonasKellerer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Is this a breaking change? When A user has set a headline, will it still work?

And we need to adapt the headline in the dashboards repo.

@fengelniederhammer
Copy link
Collaborator Author

Technically, it will probably still work, since unknown attributes would be ignored, I guess. At least I had the impression from the React example. But I would still label it breaking, because the headline disappears ;)

@fengelniederhammer fengelniederhammer merged commit 47a6626 into main Jul 18, 2024
7 checks passed
@fengelniederhammer fengelniederhammer deleted the 350-remove-headlines-from-components branch July 18, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove headlines from components
2 participants