Number of sequences over time: implement line chart view #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I think that filling up with 0 makes sense, is there a reason why you wouldn't fill it up? |
To indicate that there is not data (as opposed to data is 0). But it doesn't matter much. For the bar chart, I had to fill everything with 0s anyway for technical reasons. |
|
No data in this case means 0 available sequences, so I think that we should fill up with 0. |
fengelniederhammer
force-pushed
the
316-number-sequences-over-time-bar-chart
branch
from
3fdd1de to
1cef69d
Compare
fengelniederhammer
force-pushed
the
317-number-sequences-over-time-line-chart
branch
from
f60a7c8 to
5931244
Compare
JonasKellerer
approved these changes
Jul 15, 2024
components/src/preact/numberSequencesOverTime/number-sequences-over-time-line-chart.tsx
Show resolved
Hide resolved
fengelniederhammer
force-pushed
the
316-number-sequences-over-time-bar-chart
branch
3 times, most recently
from
c19e131 to
4c416c5
Compare
Base automatically changed from
316-number-sequences-over-time-bar-chart
to
main
July 15, 2024 13:08
fengelniederhammer
force-pushed
the
317-number-sequences-over-time-line-chart
branch
from
5931244 to
2e3c011
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #317
Summary
Adding line charts.
Screenshot
PR Checklist