Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number sequences over time bar chart #332

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

fengelniederhammer
Copy link
Collaborator

@fengelniederhammer fengelniederhammer commented Jul 12, 2024

resolves #316

Summary

Add the bar chart. We'll add the logarithmic scale in #333

Screenshot

image

image

PR Checklist

  • All necessary documentation has been adapted.
  • The implemented feature is covered by an appropriate test.

Copy link

vercel bot commented Jul 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 15, 2024 8:43am

Copy link
Contributor

github-actions bot commented Jul 12, 2024

This is a preview of the changelog of the next release:

0.5.5 (2024-07-15)

Features

  • components: add new component that shows the number of sequences over time (32f4dcd), closes #327
  • components: number of sequences over time: compute data (ccd27d6), closes #327
  • components: number of sequences over time: implement bar chart view (39def2e), closes #316
  • components: number of sequences over time: implement table view (b52021a), closes #318

Copy link
Collaborator

@JonasKellerer JonasKellerer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

There are currently no errorbars, and I didn't find a related ticket. We might want to add one.

components/tests/visualizationStories.ts Outdated Show resolved Hide resolved
components/tests/visualizationStories.ts Outdated Show resolved Hide resolved
@fengelniederhammer fengelniederhammer force-pushed the 318-number-sequences-over-time-data-table branch from 83b0868 to 61a27d5 Compare July 15, 2024 08:11
@fengelniederhammer
Copy link
Collaborator Author

We decided that we don't implement error bars in this diagram (yet).

@chaoran-chen
Copy link
Member

@JonasKellerer, how would you envision an error bar? :)

@fengelniederhammer fengelniederhammer force-pushed the 318-number-sequences-over-time-data-table branch from 61a27d5 to 42388e8 Compare July 15, 2024 08:18
@fengelniederhammer fengelniederhammer force-pushed the 316-number-sequences-over-time-bar-chart branch from 1cef69d to a5651bf Compare July 15, 2024 08:21
@fengelniederhammer fengelniederhammer force-pushed the 318-number-sequences-over-time-data-table branch from 42388e8 to 160bf86 Compare July 15, 2024 08:26
@fengelniederhammer fengelniederhammer force-pushed the 316-number-sequences-over-time-bar-chart branch from a5651bf to c19e131 Compare July 15, 2024 08:30
@JonasKellerer
Copy link
Collaborator

The errorbar depends on what we want to display. If we want to display a "measurement" we should include one, since all measurements are bound to have uncertainties. In this case I think of statistical uncertainty, so the user knows that there are only few measurements, but due to statistical fluctuations there could also be different values. This is important to see trends in the data and not mistake some outlier for "real". I think this is what we have done in prevalence over time. However, if we only want to provide the raw data, then no errorbar is needed.

Base automatically changed from 318-number-sequences-over-time-data-table to main July 15, 2024 08:34
@fengelniederhammer fengelniederhammer force-pushed the 316-number-sequences-over-time-bar-chart branch from c19e131 to 4c416c5 Compare July 15, 2024 08:42
@fengelniederhammer fengelniederhammer merged commit 4d4d784 into main Jul 15, 2024
7 checks passed
@fengelniederhammer fengelniederhammer deleted the 316-number-sequences-over-time-bar-chart branch July 15, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Number sequences over time: bar chart
3 participants