-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Number sequences over time: data table #331
Merged
fengelniederhammer
merged 2 commits into
main
from
318-number-sequences-over-time-data-table
Jul 15, 2024
Merged
Number sequences over time: data table #331
fengelniederhammer
merged 2 commits into
main
from
318-number-sequences-over-time-data-table
Jul 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This is a preview of the changelog of the next release: 0.5.5 (2024-07-15)Features |
da0eddd
to
814b9c9
Compare
39f923d
to
83b0868
Compare
36df790
to
26a592f
Compare
JonasKellerer
approved these changes
Jul 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Only minor changes.
components/src/preact/numberSequencesOverTime/number-sequences-over-time.stories.tsx
Outdated
Show resolved
Hide resolved
components/src/web-components/visualization/gs-number-sequences-over-time.stories.ts
Outdated
Show resolved
Hide resolved
components/src/preact/numberSequencesOverTime/getNumberOfSequencesOverTimeTableData.ts
Show resolved
Hide resolved
components/src/web-components/visualization/gs-number-sequences-over-time.stories.ts
Outdated
Show resolved
Hide resolved
components/src/web-components/visualization/gs-number-sequences-over-time.tsx
Outdated
Show resolved
Hide resolved
2 tasks
26a592f
to
113a0ed
Compare
83b0868
to
61a27d5
Compare
Base automatically changed from
327-number-sequences-over-time-implement-skeleton
to
main
July 15, 2024 08:18
61a27d5
to
42388e8
Compare
42388e8
to
160bf86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #318
Summary
Adding the table view and the web component storybook (including snapshot tests).
Screenshot
PR Checklist