refactor(components): improve types of getMinMaxTemporal

If the input values are narrowed to a specific version of `Temporal`, the result will also be typed to that specific version.
GenSpectrum · Jul 19, 2024 · b07e0ac · b07e0ac
1 parent 24d18d5
commit b07e0ac
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/components/src/query/queryRelativeGrowthAdvantage.ts b/components/src/query/queryRelativeGrowthAdvantage.ts
@@ -28,12 +28,10 @@ export async function queryRelativeGrowthAdvantage<LapisDateField extends string
         mapNumerator.evaluate(lapis, signal),
         mapDenominator.evaluate(lapis, signal),
     ]);
-    const { min, max } = getMinMaxTemporal(denominatorData.content.map((d) => d.date));
-    if (!min && !max) {
+    const { min: minDate, max: maxDate } = getMinMaxTemporal(denominatorData.content.map((d) => d.date));
+    if (!minDate && !maxDate) {
         return null;
     }
-    const minDate = min as YearMonthDay;
-    const maxDate = max as YearMonthDay;
 
     const numeratorCounts = new Map<YearMonthDay, number>();
     numeratorData.content.forEach((d) => {

diff --git a/components/src/utils/temporal.ts b/components/src/utils/temporal.ts
@@ -345,9 +345,9 @@ export function compareTemporal(a: Temporal | null, b: Temporal | null): number
     return 0;
 }
 
-export function getMinMaxTemporal(values: Iterable<Temporal | null>) {
-    let min = null;
-    let max = null;
+export function getMinMaxTemporal<T extends Temporal>(values: Iterable<T | null>) {
+    let min: T | null = null;
+    let max: T | null = null;
     for (const value of values) {
         if (value === null) {
             continue;