feat(components): set min proportion for initial query to 0.001

GenSpectrum · Jul 19, 2024 · 7d982a8 · 7d982a8
1 parent 24d18d5
commit 7d982a8
Show file tree

Hide file tree

Showing 2 changed files with 85 additions and 15 deletions.
diff --git a/components/src/query/queryMutationsOverTime.spec.ts b/components/src/query/queryMutationsOverTime.spec.ts
@@ -21,15 +21,30 @@ describe('queryMutationsOverTime', () => {
         lapisRequestMocks.multipleMutations(
             [
                 {
-                    body: { ...lapisFilter, dateFieldFrom: '2023-01-01', dateFieldTo: '2023-01-01', minProportion: 0 },
+                    body: {
+                        ...lapisFilter,
+                        dateFieldFrom: '2023-01-01',
+                        dateFieldTo: '2023-01-01',
+                        minProportion: 0.001,
+                    },
                     response: { data: [getSomeTestMutation(0.1), getSomeOtherTestMutation(0.4)] },
                 },
                 {
-                    body: { ...lapisFilter, dateFieldFrom: '2023-01-02', dateFieldTo: '2023-01-02', minProportion: 0 },
+                    body: {
+                        ...lapisFilter,
+                        dateFieldFrom: '2023-01-02',
+                        dateFieldTo: '2023-01-02',
+                        minProportion: 0.001,
+                    },
                     response: { data: [getSomeTestMutation(0.2)] },
                 },
                 {
-                    body: { ...lapisFilter, dateFieldFrom: '2023-01-03', dateFieldTo: '2023-01-03', minProportion: 0 },
+                    body: {
+                        ...lapisFilter,
+                        dateFieldFrom: '2023-01-03',
+                        dateFieldTo: '2023-01-03',
+                        minProportion: 0.001,
+                    },
                     response: { data: [getSomeTestMutation(0.3)] },
                 },
             ],
@@ -70,15 +85,30 @@ describe('queryMutationsOverTime', () => {
         lapisRequestMocks.multipleMutations(
             [
                 {
-                    body: { ...lapisFilter, dateFieldFrom: '2023-01-01', dateFieldTo: '2023-01-01', minProportion: 0 },
+                    body: {
+                        ...lapisFilter,
+                        dateFieldFrom: '2023-01-01',
+                        dateFieldTo: '2023-01-01',
+                        minProportion: 0.001,
+                    },
                     response: { data: [getSomeTestMutation(0.1), getSomeOtherTestMutation(0.4)] },
                 },
                 {
-                    body: { ...lapisFilter, dateFieldFrom: '2023-01-02', dateFieldTo: '2023-01-02', minProportion: 0 },
+                    body: {
+                        ...lapisFilter,
+                        dateFieldFrom: '2023-01-02',
+                        dateFieldTo: '2023-01-02',
+                        minProportion: 0.001,
+                    },
                     response: { data: [] },
                 },
                 {
-                    body: { ...lapisFilter, dateFieldFrom: '2023-01-03', dateFieldTo: '2023-01-03', minProportion: 0 },
+                    body: {
+                        ...lapisFilter,
+                        dateFieldFrom: '2023-01-03',
+                        dateFieldTo: '2023-01-03',
+                        minProportion: 0.001,
+                    },
                     response: { data: [getSomeTestMutation(0.3)] },
                 },
             ],
@@ -119,15 +149,30 @@ describe('queryMutationsOverTime', () => {
         lapisRequestMocks.multipleMutations(
             [
                 {
-                    body: { ...lapisFilter, dateFieldFrom: '2023-01-01', dateFieldTo: '2023-01-01', minProportion: 0 },
+                    body: {
+                        ...lapisFilter,
+                        dateFieldFrom: '2023-01-01',
+                        dateFieldTo: '2023-01-01',
+                        minProportion: 0.001,
+                    },
                     response: { data: [] },
                 },
                 {
-                    body: { ...lapisFilter, dateFieldFrom: '2023-01-02', dateFieldTo: '2023-01-02', minProportion: 0 },
+                    body: {
+                        ...lapisFilter,
+                        dateFieldFrom: '2023-01-02',
+                        dateFieldTo: '2023-01-02',
+                        minProportion: 0.001,
+                    },
                     response: { data: [] },
                 },
                 {
-                    body: { ...lapisFilter, dateFieldFrom: '2023-01-03', dateFieldTo: '2023-01-03', minProportion: 0 },
+                    body: {
+                        ...lapisFilter,
+                        dateFieldFrom: '2023-01-03',
+                        dateFieldTo: '2023-01-03',
+                        minProportion: 0.001,
+                    },
                     response: { data: [] },
                 },
             ],
@@ -158,11 +203,21 @@ describe('queryMutationsOverTime', () => {
         lapisRequestMocks.multipleMutations(
             [
                 {
-                    body: { ...lapisFilter, dateFieldFrom: '2023-01-02', dateFieldTo: '2023-01-02', minProportion: 0 },
+                    body: {
+                        ...lapisFilter,
+                        dateFieldFrom: '2023-01-02',
+                        dateFieldTo: '2023-01-02',
+                        minProportion: 0.001,
+                    },
                     response: { data: [getSomeTestMutation(0.2)] },
                 },
                 {
-                    body: { ...lapisFilter, dateFieldFrom: '2023-01-03', dateFieldTo: '2023-01-03', minProportion: 0 },
+                    body: {
+                        ...lapisFilter,
+                        dateFieldFrom: '2023-01-03',
+                        dateFieldTo: '2023-01-03',
+                        minProportion: 0.001,
+                    },
                     response: { data: [getSomeTestMutation(0.3)] },
                 },
             ],
@@ -198,11 +253,21 @@ describe('queryMutationsOverTime', () => {
         lapisRequestMocks.multipleMutations(
             [
                 {
-                    body: { ...lapisFilter, dateFieldFrom: '2023-01-01', dateFieldTo: '2023-01-01', minProportion: 0 },
+                    body: {
+                        ...lapisFilter,
+                        dateFieldFrom: '2023-01-01',
+                        dateFieldTo: '2023-01-01',
+                        minProportion: 0.001,
+                    },
                     response: { data: [getSomeTestMutation(0.1)] },
                 },
                 {
-                    body: { ...lapisFilter, dateFieldFrom: '2023-01-02', dateFieldTo: '2023-01-02', minProportion: 0 },
+                    body: {
+                        ...lapisFilter,
+                        dateFieldFrom: '2023-01-02',
+                        dateFieldTo: '2023-01-02',
+                        minProportion: 0.001,
+                    },
                     response: { data: [getSomeTestMutation(0.2)] },
                 },
             ],
@@ -238,7 +303,12 @@ describe('queryMutationsOverTime', () => {
         lapisRequestMocks.multipleMutations(
             [
                 {
-                    body: { ...lapisFilter, dateFieldFrom: '2023-01-02', dateFieldTo: '2023-01-02', minProportion: 0 },
+                    body: {
+                        ...lapisFilter,
+                        dateFieldFrom: '2023-01-02',
+                        dateFieldTo: '2023-01-02',
+                        minProportion: 0.001,
+                    },
                     response: { data: [getSomeTestMutation(0.2)] },
                 },
             ],

diff --git a/components/src/query/queryMutationsOverTime.ts b/components/src/query/queryMutationsOverTime.ts
@@ -123,7 +123,7 @@ function fetchAndPrepareDates<LapisDateField extends string>(
 }
 
 function fetchAndPrepareSubstitutionsOrDeletions(filter: LapisFilter, sequenceType: SequenceType) {
-    return new FetchSubstitutionsOrDeletionsOperator(filter, sequenceType, 0);
+    return new FetchSubstitutionsOrDeletionsOperator(filter, sequenceType, 0.001);
 }
 
 export function groupByMutation(data: MutationOverTimeData[]) {