Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: 🧪 Skip calibrations test (unused for now), keep issue open #64

Merged
merged 1 commit into from
Oct 10, 2024
Merged

test: 🧪 Skip calibrations test (unused for now), keep issue open #64

merged 1 commit into from
Oct 10, 2024

Conversation

teald
Copy link
Member

@teald teald commented Sep 30, 2024

Summary

This PR tracks the resolution of Issue #62, which involves associated calibrations no longer matching the number expected.

TODO

  • Recreate the test using non-astrodata code.
    • Remove magic number from test_get_associated_calibrations, if possible.
  • Skip the test in the development branch
    • This is unused outside of this test, I think it was meant to be used in previous testing.
    • It's unclear if this has "worked" in the past, it's a magic number and may not be reliable.

@teald teald self-assigned this Sep 30, 2024
@teald teald added external Bugs that are caused by external dependencies and other factors. test Related to testing labels Sep 30, 2024
@teald teald marked this pull request as ready for review October 10, 2024 18:35
@teald teald merged commit fb36e71 into main Oct 10, 2024
14 checks passed
@teald teald deleted the fix/associated_calibrations branch October 10, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@teald teald

Labels
external Bugs that are caused by external dependencies and other factors. test Related to testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@teald