Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build/Release testing #46

Merged
merged 32 commits into from
Aug 9, 2024
Merged

Build/Release testing #46

merged 32 commits into from
Aug 9, 2024

Conversation

teald
Copy link
Member

@teald teald commented Aug 7, 2024

Summary

This tests astrodata against built and "published" packages using devpi as a PyPI mirror. This is a major step towards ensuring issues like Issue #28 are caught, which often pass in local testing.

Major changes

  • Add build test support with a dedicated PyPI mirror
    • Can run locally or via github actions
    • devpi is only additional dependency
  • Update development docs for nox usage
  • Add nox sessions for creating venvs and conda envs with dependencies installed
nox -s devshell  # Create a development .venv
nox -s devconda  # Create a development conda env

Other changes

  • Update the formatting and linting workflows to consolidate settings into the pyproject.toml
    • Previously, these were a bit scattered (some set in .pre-commit-config.yaml, others set in pyproject.toml or in environment variables/global settings.

Notes

  • Given the general use cases for spinning up isolated, temporary devpi servers in isolated environments, that component will likely be extracted into some kind of nox plugin or utility.

@teald teald changed the title Test/build testing Build/Release testing Aug 7, 2024
@teald teald self-assigned this Aug 7, 2024
@teald teald added documentation Improvements or additions to documentation enhancement New feature or request dependencies Pull requests that update a dependency file CI/CD Changes to CI/CD workflows test Related to testing labels Aug 7, 2024
teald added 13 commits August 6, 2024 17:15
Add `tomli`, update `ruff`, remove `tox`
…abled.

Right now, the code is not in need of linting with all of `ruff`'s rules. But I had some time to look through some of the rules when all are selected, and there are a numebr of useful ones in there for, e.g., documentation and catching possible bugs. This list should be treated as things that are not to be immediately implemented, or that have specific reasons/standards for beingin the code. This is on top of already-ignored rules with issues assigned.
The rules are now deselected, I was doing some work with all rules
selected for a bit.
@teald teald marked this pull request as ready for review August 9, 2024 18:25
@teald teald merged commit 7c59f6b into main Aug 9, 2024
10 checks passed
@teald teald deleted the test/build_testing branch August 9, 2024 19:12
@teald teald added the PyOpenSci Review Part of a PyOpenSci Review label Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Changes to CI/CD workflows dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation enhancement New feature or request PyOpenSci Review Part of a PyOpenSci Review test Related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant