Change to 'assert' message to hunt memory leaks

Change to 'assert' for GSAOI test
GeminiDRSoftware · Feb 2, 2024 · 06014e1 · 06014e1
1 parent 2526134
commit 06014e1
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/geminidr/gmos/recipes/ql/tests/test_ls_spect.py b/geminidr/gmos/recipes/ql/tests/test_ls_spect.py
@@ -158,7 +158,8 @@ def reduce(file_list, label, calib_files, recipe_name=None, save_to=None,
         [os.remove(f) for f in r.output_filenames]
 
     # check that we are not leaking objects
-    assert len(objgraph.by_type('NDAstroData')) == 0
+    assert len(objgraph.by_type('NDAstroData')) == 0, ("Leaking objects",
+           [x.shape for x in objgraph.by_type('NDAstroData')])
 
     return calib_files
 

diff --git a/geminidr/gmos/recipes/sq/tests/test_ls_spect.py b/geminidr/gmos/recipes/sq/tests/test_ls_spect.py
@@ -157,7 +157,8 @@ def reduce(file_list, label, calib_files, recipe_name=None, save_to=None,
         [os.remove(f) for f in r.output_filenames]
 
     # check that we are not leaking objects
-    assert len(objgraph.by_type('NDAstroData')) == 0
+    assert len(objgraph.by_type('NDAstroData')) == 0, ("Leaking objects",
+           [x.shape for x in objgraph.by_type('NDAstroData')])
 
     return calib_files
 

diff --git a/geminidr/gsaoi/recipes/tests/test_reduce_gsaoi.py b/geminidr/gsaoi/recipes/tests/test_reduce_gsaoi.py
@@ -115,7 +115,10 @@ def reduce(file_list, label, calib_files, recipe_name=None, save_to=None,
         [os.remove(f) for f in r.output_filenames]
 
     # check that we are not leaking objects
-    assert len(objgraph.by_type('NDAstroData')) == 0
+    assert len(objgraph.by_type('NDAstroData')) == 0, ("Leaking objects",
+           [x.shape for x in objgraph.by_type('NDAstroData')],
+           [x.filename for x in objgraph.by_type("AstroDataGsaoi")],
+           f'{label=}')
 
     return output_file, calib_files