Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(send): new command send #3288

Merged
merged 6 commits into from
Feb 20, 2021
Merged

feat(send): new command send #3288

merged 6 commits into from
Feb 20, 2021

Conversation

dgibbs64
Copy link
Member

@dgibbs64 dgibbs64 commented Feb 20, 2021 •
edited
Loading

Description

Added a function to send command directly to the console

Fixes #1917

Type of change

  • Bug fix (a change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request Subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have checked that this code is commented where required.
  • I have provided a detailed with enough description of this PR.
  • I have checked If documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

0DUDDU and others added 4 commits February 20, 2021 13:04
@0DUDDU @dgibbs64 @Frisasky
add send command to console (#2350)
770f969 
* add send command

Added a function to send command directly to the console
If the user don't provide a command right after the "send" argument, he will be prompt to enter a command

* updates to messages

converted spaces to tabs

* minor

* minor

* messages only display if manual entry

* updated description

* send will not show if not supported

* corrected if changed to !

* ui updates

* ui changes

* Update core_getopt.sh

Co-authored-by: Daniel Gibbs <[email protected]>
Co-authored-by: Frisasky <[email protected]>
@dgibbs64
minor changes
3f6b8e0
@dgibbs64
ui changes
5a01a99
@dgibbs64
more ui stuff
17d1122
@dgibbs64 dgibbs64 added the type: feature request New feature or request label Feb 20, 2021
@dgibbs64 dgibbs64 added this to the v21.2.0 milestone Feb 20, 2021
@dgibbs64 dgibbs64 self-assigned this Feb 20, 2021
@dgibbs64 dgibbs64 requested a review from h3o66 February 20, 2021 21:42
@h3o66
Copy link
Member

h3o66 commented Feb 20, 2021

What about adding a check for consoleinteract for this ?
Because if you cannot interact with the console, this would not work anyway.

@dgibbs64
Copy link
Member Author

What about adding a check for consoleinteract for this ?
Because if you cannot interact with the console, this would not work anyway.

https://github.com/GameServerManagers/LinuxGSM/pull/3288/files#diff-3bc6a58c2eb5abd7fd1763b442bd4b3ae61f1df133ff7980fd33222b4bd6362aR90

@dgibbs64 dgibbs64 changed the title Feature/2334 send command feat(send): new command send Feb 20, 2021
h3o66
h3o66 approved these changes Feb 20, 2021
View reviewed changes
Copy link
Member

@h3o66 h3o66 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine with that, nothing obvious

@dgibbs64 dgibbs64 merged commit 0ca6c8a into develop Feb 20, 2021
@dgibbs64 dgibbs64 deleted the feature/2334-send-command branch February 20, 2021 22:33
@dgibbs64 dgibbs64 linked an issue Feb 20, 2021 that may be closed by this pull request
Send command to console #1917
Closed
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@h3o66 h3o66 h3o66 approved these changes

Assignees

@dgibbs64 dgibbs64

Labels
command: console command: update type: feature request New feature or request
Projects
None yet
Milestone
v21.2.0
Development

Successfully merging this pull request may close these issues.

Send command to console
3 participants
@dgibbs64 @h3o66 @0DUDDU