Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add send command to console #2350

Conversation

0DUDDU
Copy link
Contributor

@0DUDDU 0DUDDU commented May 10, 2019

Added a function to send command directly to the console
If the user don't provide a command right after the "send" argument, he will be prompt to enter a command

Fixes #1917 #2334

Type of change

  • Bug fix (change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).
  • This change requires a documentation update.

Checklist

  • This code follows the style guidelines of this project.
  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • I have performed a self-review of my own code.
  • I have squashed commits.
  • I have commented my code, particularly in hard to understand areas.
  • I have made corresponding changes to the documentation if required.

Provide Github Email

Co-authored-by: DUDU54 <[email protected]>

Added a function to send command directly to the console
If the user don't provide a command right after the "send" argument, he will be prompt to enter a command
@dgibbs64
Copy link
Member

Amazing the support this project is getting from people! There are so many features I simply don't have time to develop and others are taking it upon themselves to help out. Thank you!

@Frisasky
Copy link
Contributor

link issue #2334

@GameServerManagers GameServerManagers deleted a comment May 12, 2019
converted spaces to tabs
@GameServerManagers GameServerManagers deleted a comment May 12, 2019
@dgibbs64 dgibbs64 self-requested a review May 12, 2019 21:54
@GameServerManagers GameServerManagers deleted a comment May 12, 2019
@GameServerManagers GameServerManagers deleted a comment May 12, 2019
@GameServerManagers GameServerManagers deleted a comment May 12, 2019
@GameServerManagers GameServerManagers deleted a comment Jun 10, 2019
@dgibbs64 dgibbs64 added the type: feature request New feature or request label Jun 12, 2019
@dgibbs64 dgibbs64 requested a review from a team June 12, 2019 15:21
@dgibbs64 dgibbs64 closed this Jun 15, 2019
@dgibbs64 dgibbs64 reopened this Jun 15, 2019
@GameServerManagers GameServerManagers deleted a comment Jul 12, 2019
@dgibbs64
Copy link
Member

This command should only be made available to compatible servers

Copy link
Member

@dgibbs64 dgibbs64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with this command. The only thing that needs to be done is to only allow it to be added to compatible servers. So a new var in _default.cfg should be added something like sendconsole="1". I will look at adding this setting before merge. Thanks for this

@GameServerManagers GameServerManagers deleted a comment Oct 8, 2019
@ricksterhd123
Copy link

Will this have support in multi theft auto? I think this feature would be great.

@ricksterhd123
Copy link

This is a perfect feature but no one is active to approve it :(

@dgibbs64 dgibbs64 closed this Nov 15, 2019
@dgibbs64 dgibbs64 reopened this Nov 15, 2019
@vinanrra
Copy link

This will be awesome to add, because with Docker container you will be able to show the info at logs

@ricksterhd123
Copy link

ricksterhd123 commented Jan 24, 2020

This will be awesome to add, because with Docker container you will be able to show the info at logs

Indeed, it would be very convenient - hopefully it gets merged soon, I kinda ought to test it for myself.
@dgibbs64 What's the ETA for this?

@dgibbs64
Copy link
Member

Just an update on this. Once issue #2844 is complete I will be able to merge this as it will allow this command to only show with servers that are compatible with it.

@dgibbs64 dgibbs64 closed this Jan 27, 2021
@dgibbs64 dgibbs64 deleted the branch GameServerManagers:feature/2334-send-command January 27, 2021 20:51
@h3o66 h3o66 reopened this Jan 29, 2021
@dgibbs64 dgibbs64 self-assigned this Feb 19, 2021
@dgibbs64 dgibbs64 changed the base branch from develop to feature/2334-send-command February 20, 2021 13:04
@dgibbs64 dgibbs64 merged commit 770f969 into GameServerManagers:feature/2334-send-command Feb 20, 2021
@dgibbs64
Copy link
Member

@Dudu54 got there in the end. The send command will be part of the next release. Thank you for your contribution ❤️

@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants