Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing nominals in cryptol lib bug (solving #2230) #2233

Closed
wants to merge 2 commits into from

Conversation

mtullsen
Copy link
Contributor

Copy link
Contributor

@RyanGlScott RyanGlScott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this change in principle, but as the CI reveals, making this change now will simply cause SAW to choke when it tries to process the Option and Result enums in the Cryptol prelude. I think it would be better to include this patch as part of an eventual fix for #2052 so that we can verify that the patch works as intended.

@mtullsen mtullsen marked this pull request as draft February 22, 2025 05:07
@mtullsen
Copy link
Contributor Author

I agree with this change in principle, but as the CI reveals, making this change now will simply cause SAW to choke when it tries to process the Option and Result enums in the Cryptol prelude. I think it would be better to include this patch as part of an eventual fix for #2052 so that we can verify that the patch works as intended.

Will do. This is now part of the branch 2052-support-importing-cryptol-enums-into-sawcore

@mtullsen mtullsen closed this Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sawscript panics when nominal types are used in baked in Cryptol libraries.
2 participants