Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instances for more types from base #171

Merged
merged 6 commits into from
Feb 4, 2025

Conversation

langston-barrett
Copy link
Contributor

These aren't motivated by any particular use-case, but in general it's nice to have instances from base in case downstream packages need them, because they can only be defined in this package on pain of orphan instances.

The related barbies package has all of these.

@langston-barrett langston-barrett self-assigned this Feb 4, 2025
Copy link
Contributor

@RyanGlScott RyanGlScott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to mention these new instances in the changelog.

@langston-barrett langston-barrett merged commit d6637d1 into GaloisInc:master Feb 4, 2025
9 checks passed
@langston-barrett langston-barrett deleted the lb/apply branch February 4, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants