Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty vector #112

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Empty vector #112

wants to merge 9 commits into from

Conversation

benjaminselfridge
Copy link
Contributor

I propose changing the default Data.Parameterized.Vector data type to one that allows empty vectors. This commit does that, and puts the nonempty variant in Data.Parameterized.Vector.NonEmpty.

This a breaking change, but is fixable downstream by just changing the import.

RyanGlScott
RyanGlScott reviewed May 20, 2021
View reviewed changes
Copy link
Contributor

@RyanGlScott RyanGlScott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be worth mentioning the existence of Data.Parameterized.Vector.NonEmpty in the changelog.

@RyanGlScott
Copy link
Contributor

Of the GaloisInc repos that are on GitHub, the ones that would be affected by this change are what4, crucible, dismantle, portable-executable, and macaw. This gives us a place to start to prepare for this patch should we land it in the future.

@langston-barrett langston-barrett changed the title Feature/empty vector Empty vector Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanGlScott RyanGlScott RyanGlScott left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benjaminselfridge @RyanGlScott