Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cryptol-remote-api to 3.1.1 #1662

Merged
merged 3 commits into from
May 15, 2024

Conversation

mccleeary-galois
Copy link
Contributor

@mccleeary-galois mccleeary-galois commented May 15, 2024

Preparatory work for bumping cryptol-remote-api to version 3.1.1 for python 3.12 support

Copy link
Contributor

@RyanGlScott RyanGlScott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion: can you have one commit that bumps the pyproject.toml version to 3.1.1 (the release version), and then a subsequent commit that bumps it again to 3.1.1.99 (the development version)? We want to tag the commit that bumps it to the release version (using the tag name cryptol-remote-api-3.1.1 to keep with prior conventions), but we don't want to tag the commit that bumps it to the development version.

@mccleeary-galois mccleeary-galois force-pushed the rem/cryptol-remote-api-v3.1.1 branch from 8632ba3 to 42ee417 Compare May 15, 2024 21:20
@mccleeary-galois mccleeary-galois marked this pull request as ready for review May 15, 2024 21:27
@mccleeary-galois mccleeary-galois merged commit 784bbaa into master May 15, 2024
45 checks passed
@mccleeary-galois mccleeary-galois deleted the rem/cryptol-remote-api-v3.1.1 branch May 15, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants