crucible-llvm: Refactor and export override pipe-fitting code #1193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The goal is to clean it up a bit and export it.
Make it not panic by default, to make it usable by other clients who may not want to panic. Also, clear up the phase boundary to handle errors (e.g., in the case for structs).
|
I have tested this using a non-Crucible-LLVM frontend, and it appears to work as intended. |
RyanGlScott
approved these changes
Mar 27, 2024
Co-authored-by: Ryan Scott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code in question converts between bitvectors and pointers so that it is easy and natural to specify overrides using bitvectors, while at runtime only LLVM pointers are used. The built-in overrides (e.g., for libc) all expect to be wrapped in this casting code. They're all exported, so to make them usable by downstream clients, we also need to export the code that does the pipe-fitting.