-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Build and test both x86-64 and AArch64 macOS #1173
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the conventions for crux-llvm and crux-mir were inconsistent in a number of ways, which this PR fixes. We now: * Build both using three recent versions of GHC on Linux * Build other OSes using only a single version of GHC, which is now consistent * Use the same naming conventions when uploading binary artifacts
This also requires bumping the `mir-json` submodule to bring in the changes from GaloisInc/mir-json#65, which are necessary to make `mir-json` build with AArch64 Macs.
f56050d
to
d28f7c5
Compare
Happily, the There is a single test that fails in the
And indeed, |
This test case requires an x86-64 compiler in order to work, so it stands no hope of working on other architectures (e.g., AArch64 on Apple silicon).
kquick
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also requires bumping the
mir-json
submodule to bring in the changes from GaloisInc/mir-json#65, which are necessary to makemir-json
build with AArch64 Macs.