Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jsbsim_proxy for use with ArduPilot #111

Merged
merged 5 commits into from
Sep 25, 2024
Merged

Add jsbsim_proxy for use with ArduPilot #111

merged 5 commits into from
Sep 25, 2024

Conversation

spernsteiner
Copy link
Collaborator

@spernsteiner spernsteiner commented Sep 13, 2024

This adds a jsbsim_proxy tool, which can be used in conjunction with the ArduPilot SITL jsbsim_ext model (GaloisInc/verse-ardupilot#1) to run JSBSim on a separate machine from the arduplane SITL binary. See the jsbsim_proxy README for instructions, and see the comment at the top of jsbsim_proxy.c for details of the design.

Part of #97

Checklist before requesting a review

  • I have performed a self-review of my code
  • My code matches the coding standards and I have ran the appropriate linters
  • I included documentation updates for my code
  • I extended the test suite and the tests run by the CI to cover my code
  • I assigned a Milestone to this PR
  • I assigned this PR to a Project
  • I assigned this PR appropriate Labels

@spernsteiner spernsteiner added the application software application software components label Sep 13, 2024
@spernsteiner spernsteiner added this to the Someday milestone Sep 13, 2024
@spernsteiner spernsteiner mentioned this pull request Sep 16, 2024
4 tasks
Base automatically changed from 97-ardupilot-build to main September 23, 2024 17:22
Copy link
Collaborator

@podhrmic podhrmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a few questions, otherwise LGTM

command -v JSBSim || echo "JSBSim not found"
$verse_opensut/src/jsbsim_proxy/jsbsim_proxy JSBSim \
--suspend \
--simulation-rate=1200 \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the sim rate really 1200Hz? Or does this mean something else?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, default sim rate for --model jsbsim is 1200 Hz. I did some experiments with lower sim rates, but the JSBSim physics model seems to become unstable below about 500 Hz.

build/sitl/bin/arduplane \
--synthetic-clock \
--model jsbsim_ext \
--speedup 1 \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does speedup 1 do? Does it mean effectively realtime speed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure - these options are copied from the defaults used in sim_vehicle.py

@spernsteiner spernsteiner merged commit a25f42e into main Sep 25, 2024
15 checks passed
@spernsteiner spernsteiner deleted the 97-jsbsim-proxy branch September 25, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
application software application software components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants