-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add jsbsim_proxy for use with ArduPilot #111
Conversation
7cbd809
to
ee68f6e
Compare
ee68f6e
to
baf2d26
Compare
ea5e1dc
to
5f84a4f
Compare
baf2d26
to
8d544e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a few questions, otherwise LGTM
command -v JSBSim || echo "JSBSim not found" | ||
$verse_opensut/src/jsbsim_proxy/jsbsim_proxy JSBSim \ | ||
--suspend \ | ||
--simulation-rate=1200 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the sim rate really 1200Hz? Or does this mean something else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, default sim rate for --model jsbsim
is 1200 Hz. I did some experiments with lower sim rates, but the JSBSim physics model seems to become unstable below about 500 Hz.
build/sitl/bin/arduplane \ | ||
--synthetic-clock \ | ||
--model jsbsim_ext \ | ||
--speedup 1 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does speedup 1
do? Does it mean effectively realtime speed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not entirely sure - these options are copied from the defaults used in sim_vehicle.py
This adds a
jsbsim_proxy
tool, which can be used in conjunction with the ArduPilot SITLjsbsim_ext
model (GaloisInc/verse-ardupilot#1) to run JSBSim on a separate machine from thearduplane
SITL binary. See thejsbsim_proxy
README for instructions, and see the comment at the top ofjsbsim_proxy.c
for details of the design.Part of #97
Checklist before requesting a review