Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow for the parameter bounds to be splines #186

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

allow for the parameter bounds to be splines #186

wants to merge 9 commits into from

Conversation

nstarman
Copy link
Collaborator

Description

This pull request is to address ...

Fixes #

PR Checklist

  • Check out the contributing guidelines and code of conduct
  • Check out the contributing workflow ( for a practical example click here )
  • Give a detailed description of the PR above.
  • Document changes in the CHANGES.rst file. See existing changelog for examples.
  • Add tests, if applicable, to ensure code coverage never decreases.
  • Make sure the docs are up to date, if applicable, particularly the docstrings and RST files in docs folder.
  • Ensure linear history by rebasing, when requested by the maintainer.

@nstarman nstarman added this to the v0.2 milestone Dec 10, 2023
nstarman
nstarman commented Feb 6, 2024
View reviewed changes
src/stream_mapper/core/_core/base.py Outdated
# don't require all coordinates to be present in the data,
# e.g. "distmod" on an isochrone model.
),
(~within_bounds(data[k], a[:,0], b[:,0]) for k, (a, b) in kab),
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(~within_bounds(data[k], a[:,0], b[:,0]) for k, (a, b) in kab),
(~within_bounds(data[k], a, b) for k, (a, b) in kab),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.2
Development

Successfully merging this pull request may close these issues.
1 participant
@nstarman