Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameter bound inf #181

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Parameter bound inf #181

merged 2 commits into from
Nov 17, 2023

Conversation

nstarman
Copy link
Collaborator

Allow for inf to be approximated by a large number to not break gradients.

PR Checklist

  • Check out the contributing guidelines and code of conduct
  • Check out the contributing workflow ( for a practical example click here )
  • Give a detailed description of the PR above.
  • Document changes in the CHANGES.rst file. See existing changelog for examples.
  • Add tests, if applicable, to ensure code coverage never decreases.
  • Make sure the docs are up to date, if applicable, particularly the docstrings and RST files in docs folder.
  • Ensure linear history by rebasing, when requested by the maintainer.

@nstarman
allow for inf to be set
de02c32 
inf breaks the gradient. Now inf can be approximated.

Signed-off-by: nstarman <[email protected]>
@nstarman
better str repr for control regions
a4cdff0 
Signed-off-by: nstarman <[email protected]>
@nstarman nstarman added this to the v0.1 milestone Nov 17, 2023
@nstarman nstarman merged commit 99d7daf into GalOrrery:main Nov 17, 2023
1 check passed
@nstarman nstarman deleted the parameter_bound_inf branch November 17, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.1
Development

Successfully merging this pull request may close these issues.
1 participant
@nstarman