Wrapper : Reintroduce LC_NUMERIC=C
#5159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I removed this in e323014 after verifying that the OCIO bug it worked around was now fixed properly. But what I didn't realise is that we have our _own_ equivalent bug in ImageEngine/cortex#1338. So I'm reverting the change until we have time to fix properly in Cortex. Fixes GafferHQ#5158
johnhaddon
force-pushed
the
lcNumericAgain
branch
from
5f1ab5d to
08acbfa
Compare
|
Rebased to fix merge conflict - would be good to get your review on this @ericmehl |
ericmehl
approved these changes
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed this in e323014 after verifying that the OCIO bug it worked around was now fixed properly. But what I didn't realise is that we have our own equivalent bug in ImageEngine/cortex#1338. So I'm reverting the change until we have time to fix properly in Cortex.
Fixes #5158