Talisman of Remedium no longer wastes durability trying to remove permanent debuffs. It also accepts the Unbreaking enchant. #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OneEyeMaker
requested changes
Dec 25, 2023
src/main/java/thaumic/tinkerer/common/item/ItemCleansingTalisman.java
Outdated
Show resolved
Hide resolved
src/main/java/thaumic/tinkerer/common/item/ItemCleansingTalisman.java
Outdated
Show resolved
Hide resolved
OneEyeMaker
approved these changes
Dec 26, 2023
|
I am having issues with the talisman voiding itself after enchanting it with unbreaking III, not sure if it's related to this issue. Submitted the bug here: GTNewHorizons/GT-New-Horizons-Modpack#15347 Edit: Apologies, I assumed the Remedium item did not accept the unbreaking enchant before, and that this was already live on 2.5.1. |
3 tasks
DrParadox7
pushed a commit
to DrParadox7/ThaumicTinkerer
that referenced
this pull request
Jun 12, 2024
…manent debuffs. It also accepts the Unbreaking enchant. (GTNewHorizons#36) * Talisman of Remedium accepts Unbreaking enchant. * Talisman of Remedium no longer removes debuffs with duration < 1 second. * Talisman of Remedium does not waste durability trying to remove "permanent" debuffs. * Use a map on player's UUID instead of single variables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains three changes:
The Talisman of Remedium now ignores any debuffs that have a duration of < 1 second. This means it will not attempt to remove permanent debuffs caused by picking up containers using a dolly, by wielding a TiC cleaver, from hunger, etc.
The talisman also attempts to detect other "permanent" debuffs, which are being reapplied to the player even after removed. For example, debuffs for holding a super tank, or from standing in poison or fire. If a player is affected by such a debuff, the talisman will not keep consuming durability or making noise trying to remove the debuff. The debuff will then be silently removed when the condition that keeps reapplying it stops doing so. (E.g., when the player places down the super tank.)
Finally, the talisman can now be enchanted with the Unbreaking enchant using any standard means. The enchant functions identically to other tools; i.e., adds a chance not to consume durability with every use.
I have also planned to support the Repair enchant; however it seems to be hardcoded in base TC to only check items in the player's hotbar and armor slots. If anyone (@Alastors ?) wants to poke at it and make it apply to bauble slots too, I would be happy to add support.