Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cleanup for the fake essentia items #80

Merged
merged 6 commits into from
Jan 9, 2025

Conversation

RecursivePineapple
Copy link

The existing code will generate fake essentia items to finish crafting CPU jobs, but it never removes those items. Even if you remove all essentia from the ME system, these items will never be removed.

This adds two mechanisms for removing these fake items. First, it removes the items when inserted into the ME system. Secondly, it will poll the ME system (it already had to do this to determine what essentia can be craft) whenever the essentia levels change and remove any fake items left over (e.g. from prior essentia crafting jobs).

The existing code will generate fake essentia items to finish crafting
CPU jobs, but it never removes those items. Even if you remove all
essentia from the ME system, these items will never be removed.

This adds two mechanisms for removing these fake items. First, it
removes the items when inserted into the ME system. Secondly, it will
poll the ME system (it already had to do this to determine what essentia
can be craft) whenever the essentia levels change and remove any fake
items left over (e.g. from prior essentia crafting jobs).
@RecursivePineapple RecursivePineapple added the bug Something isn't working label Nov 19, 2024
@RecursivePineapple RecursivePineapple requested a review from a team November 19, 2024 19:28
@AbdielKavash
Copy link
Member

AbdielKavash commented Nov 20, 2024

Just want to confirm this, I am not at all opposed to the fix: this completely breaks this method of automation, right? https://gtnh.miraheze.org/wiki/Complete_Guide_to_Thaumic_Energistics_Automation

If so I will remove it from the wiki.

@RecursivePineapple
Copy link
Author

@AbdielKavash
Yes, this PR would break that. It looks like that automation is actually useful, so we have two options here. We can either close this PR (it's optional, but it's the 'correct' behaviour), or do something similar to this: GTNewHorizons/AE2FluidCraft-Rework#245.

I'd have to change base AE to check the essentia grid cache when it checks a crafting job's stored amount instead of checking for the item. It'd be pretty simple and it'd probably be more useful than the existing system since you wouldn't have to grab the ThE fake essentia when encoding an infusion pattern.

@AbdielKavash
Copy link
Member

That is one setup that I will be very happy to see broken, if it means we can put something more sane in its place.

I said this every time someone asked about it (including on the page itself), that it is based on what I consider a bug and might get fixed at any point. I am not at all advocating for giving it any kind of life support, I will be happy to be able to delete it from existence and from my memory.

@MCTBL
Copy link
Member

MCTBL commented Nov 29, 2024

maybe we should add a method in AE2, and this method can help like fake crafting card working too.

@Ethryan
Copy link

Ethryan commented Nov 29, 2024

I say merge this and have something that doesn’t have a large chance of filling up your drives with invisible fake items at the slightest error.

Sounds like a nice fix to me.

@serenibyss serenibyss added the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label Dec 29, 2024
Copy link

@OneEyeMaker OneEyeMaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also suggest merging this PR If one doesn't cause any issues during testing.

@Dream-Master
Copy link
Member

It was on zeta for a few weeks

@Dream-Master Dream-Master merged commit 0ac86e3 into master Jan 9, 2025
2 checks passed
@Dream-Master Dream-Master deleted the cleanup-fake-essentia-items branch January 9, 2025 11:43
@Dream-Master Dream-Master removed the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants