-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added cleanup for the fake essentia items #80
Conversation
The existing code will generate fake essentia items to finish crafting CPU jobs, but it never removes those items. Even if you remove all essentia from the ME system, these items will never be removed. This adds two mechanisms for removing these fake items. First, it removes the items when inserted into the ME system. Secondly, it will poll the ME system (it already had to do this to determine what essentia can be craft) whenever the essentia levels change and remove any fake items left over (e.g. from prior essentia crafting jobs).
Just want to confirm this, I am not at all opposed to the fix: this completely breaks this method of automation, right? https://gtnh.miraheze.org/wiki/Complete_Guide_to_Thaumic_Energistics_Automation If so I will remove it from the wiki. |
@AbdielKavash I'd have to change base AE to check the essentia grid cache when it checks a crafting job's stored amount instead of checking for the item. It'd be pretty simple and it'd probably be more useful than the existing system since you wouldn't have to grab the ThE fake essentia when encoding an infusion pattern. |
That is one setup that I will be very happy to see broken, if it means we can put something more sane in its place. I said this every time someone asked about it (including on the page itself), that it is based on what I consider a bug and might get fixed at any point. I am not at all advocating for giving it any kind of life support, I will be happy to be able to delete it from existence and from my memory. |
maybe we should add a method in AE2, and this method can help like fake crafting card working too. |
I say merge this and have something that doesn’t have a large chance of filling up your drives with invisible fake items at the slightest error. Sounds like a nice fix to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also suggest merging this PR If one doesn't cause any issues during testing.
It was on zeta for a few weeks |
The existing code will generate fake essentia items to finish crafting CPU jobs, but it never removes those items. Even if you remove all essentia from the ME system, these items will never be removed.
This adds two mechanisms for removing these fake items. First, it removes the items when inserted into the ME system. Secondly, it will poll the ME system (it already had to do this to determine what essentia can be craft) whenever the essentia levels change and remove any fake items left over (e.g. from prior essentia crafting jobs).