Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make two provider can order essentia aspect automatic #65

Merged
merged 1 commit into from
Jul 14, 2024
Merged

Make two provider can order essentia aspect automatic #65

merged 1 commit into from
Jul 14, 2024

Conversation

MCTBL
Copy link
Member

@MCTBL MCTBL commented Jun 30, 2024

and fix spelling errors

@MCTBL
Copy link
Member Author

MCTBL commented Jun 30, 2024

Auto order with infusion provider
https://discord.com/channels/181078474394566657/603348502637969419/1256839162653310995

Auto order with essentia provider
https://discord.com/channels/181078474394566657/603348502637969419/1256847686787792916

@MCTBL MCTBL requested review from Alastors and OneEyeMaker July 1, 2024 09:11
@Dream-Master Dream-Master requested a review from a team July 14, 2024 01:52
Alastors
Alastors suggested changes Jul 14, 2024
View reviewed changes
Copy link

@Alastors Alastors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually explain what you're doing exactly, this is not up to standard in proposal

@Alastors
Copy link

Oh wait you did in discord

Alastors
Alastors approved these changes Jul 14, 2024
View reviewed changes
Copy link

@Alastors Alastors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a huge fan of the method names, but code looks fine

@Alastors
Copy link

Next time put this information directly in the ticket instead of making us have to pull up discord, please

@Dream-Master Dream-Master merged commit 4c490f2 into GTNewHorizons:master Jul 14, 2024
1 check passed
@MCTBL
Copy link
Member Author

MCTBL commented Jul 14, 2024

Next time put this information directly in the ticket instead of making us have to pull up discord, please

Sry, I'll take care of it next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alastors Alastors Alastors approved these changes

@OneEyeMaker OneEyeMaker Awaiting requested review from OneEyeMaker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MCTBL @Alastors @Dream-Master