fix memory leak fixes not working for MP #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OneEyeMaker
approved these changes
Jan 10, 2025
ChrisJStone
pushed a commit
to PFAA-Updates/NotEnoughItems
that referenced
this pull request
Jan 10, 2025
GTNewHorizons#258 addresses the memory leak in ItemMobSpawner. Unfortunately the clean up handler is not consistently called on every world unloaded. This PR fixes this issue by moving the call out of that if block (cherry picked from commit 31173a1)
ChrisJStone
added a commit
to PFAA-Updates/NotEnoughItems
that referenced
this pull request
Jan 10, 2025
Update to PFAA build includes the following cherry-picked commits Add 'Hide Item List Until Searching' option (GTNewHorizons#572) update Fix NPE in ItemsTooltipLineHandler (GTNewHorizons#589) fix memory leak fixes not working for MP (GTNewHorizons#590)
Dream-Master
added
the
safe for stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#258 addresses the memory leak in ItemMobSpawner. Unfortunately the clean up handler is not consistently called on every world unloaded. This PR fixes this issue by moving the call out of that if block.