Fix for mouse wheel not working on Wayland #77
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current code was assuming that the mouse wheel events always come in increments of 120, thus ignoring everything that is less than that. On Wayland mouse wheel events send values of -1, 0, and +1, and therefore mouse wheel didn't work at all. This fix should function correctly on both Windows and Linux with Wayland. The code could also be potentially improved for Windows. On Windows Mouse.getEventDWheel() could return a value that should be interpreted as multiple mouse wheel movements in a single event. https://learn.microsoft.com/en-us/dotnet/api/system.windows.forms.control.mousewheel?view=windowsdesktop-9.0#remarks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current code was assuming that the mouse wheel events always come in increments of 120, thus ignoring everything that is less than that. On Wayland mouse wheel events send values of -1, 0, and +1, and therefore mouse wheel didn't work at all. This fix should function correctly on both Windows and Linux with Wayland. I don't have Windows so I haven't tested it so it would be nice if someone else could confirm that it still works there.
The code could also be potentially improved for Windows. On Windows Mouse.getEventDWheel() could return a value that should be interpreted as multiple mouse wheel movements in a single event.
https://learn.microsoft.com/en-us/dotnet/api/system.windows.forms.control.mousewheel?view=windowsdesktop-9.0#remarks