Skip to content
This repository has been archived by the owner on May 25, 2024. It is now read-only.

Attempt to fix "java.lang.ArithmeticException: / by zero" #91

Closed
wants to merge 5 commits into from

Conversation

Speecker
Copy link

We ran into an issue that caused one of our Servers to crash and corrupt the World.
This is my attempt of fixing this issue for future occurences to avoid a potential crash.
See the crashlog for details.
With this PR i wanted to draw attention to this unhandled exception.
Feel free to edit the PR or let me know if my suggestion is at the wrong position here.
Feedback is welcome.

crash-2024-05-12_09.26.49-server.txt

Speecker added 3 commits May 12, 2024 21:36
Added a try-catch throw for the exception of DivideByZero
minor edit to not double check for 0
@Dream-Master Dream-Master requested a review from a team May 12, 2024 20:30
@Speecker Speecker marked this pull request as draft May 12, 2024 20:38
@Lyfts
Copy link
Member

Lyfts commented May 12, 2024

The dbz has already been fixed in #89

Speecker added 2 commits May 12, 2024 23:12
changed from Exception to RuntimeException
Updated getInfoData to throw an exception during Runtime instead
@Speecker Speecker marked this pull request as ready for review May 12, 2024 21:28
@Speecker
Copy link
Author

The dbz has already been fixed in #89

Ah ok then discard this PR i guess 🗡️

Thanks for the info :)

@Speecker Speecker closed this May 12, 2024
@Speecker Speecker deleted the patch-1 branch May 12, 2024 21:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants