Skip to content
This repository has been archived by the owner on May 25, 2024. It is now read-only.

LSC readout Time to empty/full with seconds/mins/days/years #86

Conversation

Reflex18
Copy link

@Reflex18 Reflex18 commented Apr 9, 2024

Adjusted the time to empty/full information on the LSC to now autoadjust based on the amount of time. Now it will read seconds, mins, days or even years to better display readable information to the players.

@Dream-Master Dream-Master requested a review from a team April 9, 2024 14:22
Copy link
Member

@Caedis Caedis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change

nic - could use some micro optimizations to avoid all string concats since this would be called during rendering

@Dream-Master Dream-Master merged commit 4d59f06 into GTNewHorizons:master Apr 9, 2024
1 check passed
@TrubbleAC
Copy link

The values I am able to see are off by a factor of 20 - I think the value that is being displayed needs to be changed to account for the fact that the average input is per second, not per tick.

image

In the image shown above, the actual charge time should be ~2.5 hours, not the displayed 2.12 days.

@Reflex18 Reflex18 mentioned this pull request May 11, 2024
@Reflex18
Copy link
Author

Thanks for the heads up.
Fixed it here: #90

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants