Fix rotation + flipping for GT textures #4016
Open
+80
−101
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you flip + rotate an AL, its texture doesn't match its orientation. From what I can tell, this is because structurelib and RenderBlocks rotate & flip in different orders. To fix this, I copied the face rendering code from RenderBlocks and cleaned it up significantly then modified it as needed.
While I'm sure there's a simpler/lower code way to do this, I didn't want to deal with RenderBlocks' quirks if I didn't have to. From what I can see, RenderBlocks' only benefit is AO, but I copied all of that code here. This change won't affect the angelica animation system because of this PR: GTNewHorizons/Angelica#868
This change adds a few more allocations to the ISBRH render, but I figure it's worth it to keep it simple. Pooling would reduce the allocs, but I don't want to do that unless there's a clear performance hit.
Testing done: