Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change some configs of adding new blocks #18911

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

EnderProyects
Copy link

@EnderProyects EnderProyects commented Jan 29, 2025

  • Set honey to true as talked in discord ( honey, not bees)

  • Set crimson, mangrove, azalea and warped blocks to true, they are only decorative blocks

  • Set skulk to true, it can provide some blocks to work in magic related things

- Set honey to true as talked in discord ( noney, not bees)

- Set crimson, mangrove, azalea and warped blocks to true, they are only decorative blocks

- Ser skulk to true, it can provide some blocks to work in magic related things
@Dream-Master
Copy link
Member

Enable stuff are nice but did you make a recipe or ? @EnderProyects

@EnderProyects
Copy link
Author

EnderProyects commented Jan 29, 2025

First I need them to be enable in order to make recipes, ( I will make recipes, like the others batchs of recipes I have done)

@Dream-Master Dream-Master marked this pull request as draft January 29, 2025 19:47
@Dream-Master
Copy link
Member

when recipes are added i undraft it

@EnderProyects
Copy link
Author

But if I make recipes for blocks that are not in the pack ( since is not activated) the code will not work, no?

@Dream-Master
Copy link
Member

Set recipe only true if cfg is on

@EnderProyects
Copy link
Author

@Dream-Master could you make this avalible to test in zeta?

@EnderProyects EnderProyects marked this pull request as ready for review February 4, 2025 02:06
@RecursivePineapple
Copy link

I'm not sure what recipes generated by EFR need to be removed, if any, but these config changes probably won't break anything

Copy link
Member

@Dream-Master Dream-Master left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have a few more question before merge this

@EnderProyects
Copy link
Author

I should also activate netherite now that noc is working on netherite line

@Dream-Master
Copy link
Member

i will check this ingame

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants