Fix ME Chest accepting Cells with items into its internal inventory #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More methods use these Overrides than the currently present ones in AdaptorMEChest
The Wrapper class is specifically designed for blocks that have designated slots for each side
serenibyss
reviewed
Feb 26, 2025
serenibyss
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GTNewHorizons/GT-New-Horizons-Modpack/issues/16477
The bug was introduced in PR #383. Cells are now appropriately handled when pushing into the ME Chest by reusing
WrapperMCISidedInventoryTo be clear, this fix can be bypassed if a player uses other means of transporting items, such as hoppers. Modern versions of AE2 have the same issue. I believe fixing all instances would require a separate patch on every item transportation mod which is unrealistic. I had a hopper fix during testing, but this resulted in ~ 5x worse performance than without it