[Feature] Shift to pause terminal view movement #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit just toggles a boolean with Shift. Full functionality will be implemented in a future commit.
Working: - Screen properly pauses - Adding items while paused works Broken: - When an ItemStack reaches 0, adding in more does not increment
serenibyss
approved these changes
Jan 13, 2025
serenibyss
removed
the
🚧 Testing on Zeta
4 tasks
Pilzinsel64
added a commit
to LITW-Refined/EZStorage
that referenced
this pull request
Feb 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GTNewHorizons/GT-New-Horizons-Modpack#18420
This is my attempt to reimplement #449, which was reverted in #513.
While the player is holding shift, the ItemRepo enters a paused state. When paused, instead of clearing the view and display buffers entirely and filling them from the server entries, the existing view buffer is maintained and the existing view items are updated from the server entries. Any items that were not previously in the view are appended to the end of the view. Sorting is disabled while paused.
Changes were made to the AppEngRenderingItem class to prevent non-craftable, 0 quantity IAEItemStacks from displaying the "craft" text, and instead show "0" as their quantity.
I have tested this on the world provided in the original reversion, but I would love some massively updating AE2 systems to test performance on, as well as any advice on how to go about testing ae2 performance outside of monitoring MSPT. I haven't run into any noticeable FPS TPS issues in my testing, but since the previous attempt had to be reverted I would love addition eyes.