Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change: Remove ultra dense cables #638

Merged
merged 4 commits into from
Dec 29, 2024

Conversation

szuend
Copy link

@szuend szuend commented Dec 29, 2024

Part of #550

To keep PR size reasonable for review, I'll remove textures and the ultra dense AECableTypes separately.

WARNING: Existing ultra dense cables will disappear from the world.

@szuend szuend changed the title Breaking change: Remove PartUltraDenseCable* parts Breaking change: Remove ultra dense cables Dec 29, 2024
@serenibyss
Copy link
Member

Why will this crash the client, shouldn't the blocks disappear like normal or is there something I'm missing?

@Dream-Master Dream-Master requested a review from a team December 29, 2024 18:35
@szuend
Copy link
Author

szuend commented Dec 29, 2024

All cables use the same block/TileEntity and the cable TE tries to load a part that no longer exists now. I'll do some digging to see whether we can turn this into a more graceful failure or downgrade to dense cables in-place maybe?

@serenibyss
Copy link
Member

All cables use the same block/TileEntity and the cable TE tries to load a part that no longer exists now. I'll do some digging to see whether we can turn this into a more graceful failure or downgrade to dense cables in-place maybe?

That would be great, thanks

@szuend
Copy link
Author

szuend commented Dec 29, 2024

Falling back to dense cables would require us to keep the code around for a version more and implement some kind of migration it seems.

I amended the PR (see b5670a1) to log an error instead. From local testing it seems that ultra dense cables will disappear from the world and the ultra dense cable items will show up as "Disabled item" with the default AE2 "missing item" texture.

@serenibyss
Copy link
Member

I amended the PR (see b5670a1) to log an error instead. From local testing it seems that ultra dense cables will disappear from the world and the ultra dense cable items will show up as "Disabled item" with the default AE2 "missing item" texture.

This is perfectly good solution, thanks!

@serenibyss serenibyss merged commit 0c221eb into GTNewHorizons:master Dec 29, 2024
1 check passed
@szuend szuend deleted the remove-ultra-dense-parts branch December 29, 2024 21:04
michaeldoylecs pushed a commit to michaeldoylecs/Applied-Energistics-2-Unofficial that referenced this pull request Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants