-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking change: Remove ultra dense cables #638
Breaking change: Remove ultra dense cables #638
Conversation
Why will this crash the client, shouldn't the blocks disappear like normal or is there something I'm missing? |
All cables use the same block/TileEntity and the cable TE tries to load a part that no longer exists now. I'll do some digging to see whether we can turn this into a more graceful failure or downgrade to dense cables in-place maybe? |
That would be great, thanks |
Falling back to dense cables would require us to keep the code around for a version more and implement some kind of migration it seems. I amended the PR (see b5670a1) to log an error instead. From local testing it seems that ultra dense cables will disappear from the world and the ultra dense cable items will show up as "Disabled item" with the default AE2 "missing item" texture. |
This is perfectly good solution, thanks! |
Co-authored-by: Martin Robertz <[email protected]> Co-authored-by: Maya <[email protected]>
Part of #550
To keep PR size reasonable for review, I'll remove textures and the ultra dense
AECableType
s separately.WARNING: Existing ultra dense cables will disappear from the world.