Skip to content

Commit

Permalink
fixed file provider tests to add public access key + private access k…
Browse files Browse the repository at this point in the history
…ey, added extra test
  • Loading branch information
syaamkhandaker committed Nov 13, 2024
1 parent 51f0907 commit 688c0ff
Show file tree
Hide file tree
Showing 2 changed files with 4,616 additions and 1,621 deletions.
30 changes: 27 additions & 3 deletions packages/file-service/test/file_provider.e2e-spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -100,10 +100,34 @@ describe('File Provider Tests', () => {
}
});

it('Register a provider with empty accessKey', async () => {
it('Register a provider with empty public access key', async () => {
try {
const registerRequest = {
accessKey: '',
const registerRequest: FileProviderProto.RegisterProviderRequest = {
publicAccessKey: '',
privateAccessKey: 'privateKey',
baseUrl: 'https://aws.amazon.com',
providerName: 'test_provider',
};
await new Promise((resolve) => {
fileProviderClient.registerProvider(
registerRequest,
(err: any, resp: any) => {
expect(err).not.toBeNull();
resolve(resp);
},
);
});
fail('Expected error to be thrown');
} catch (err) {
expect(err).not.toBeNull();
}
});

it('Register a provider with empty private access key', async () => {
try {
const registerRequest: FileProviderProto.RegisterProviderRequest = {
publicAccessKey: 'accessKey',
privateAccessKey: '',
baseUrl: 'https://aws.amazon.com',
providerName: 'test_provider',
};
Expand Down
Loading

0 comments on commit 688c0ff

Please sign in to comment.