-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kenny/8 Service util setup #16
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work overall! I just left some small comments. Thanks for all your hard work!
UserId is a number in authService, while a string in petService, is this intended? Also should fetchService also take the 'HEAD' and 'OPTIONS' request methods? Should the response also include the header? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great Kenny!
Service util setup
Issue Number(s): #8
What does this PR change and why?
Checklist
auth
, one forpets
Critical Changes
auth
andpets
along with the required callsRelated PRs
Testing
N/A