-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kenny/7 home navbar #15
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, great work! I appreciate you writing comments, made it easy to answer questions + give feedback. I left comments, requesting some slight changes.
Just FYI, some of the UI seems to scale a bit differently based on resolution. All icons, buttons, text bubble appears to be bigger on my end, and it bleeds off the screen a bit. I left a SS of how it looks on my end.
Also, can we capitalize component names?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work Kenny! Everything looks great. Can we try to use SVG's for all assets?
Other than that, I left some small comments. Great work!
} | ||
|
||
const ProfileName: React.FC<ProfileNameProps> = ({ name: initialName }) => { | ||
// Basic placeholder logic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for turning the name into an input! On my end, even if I click the pencil icon, I still can't edit the input though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed it a bit so it seems a more obvious that you can edit the text. Should the edit icon stay on the screen while you're editing it text though or should I replace it with a checkmark etc.
Home screen looks great, thank you so much! The only comments I have for this sprint are completely my fault: could we make the pencil icon be white? I realized in the original design I had, i made it black so that is completely my fault! I have updated the design on the Figma to have a white icon with a drop shadow if you could use that instead? |
Create the home page + nav bar
Issue Number(s): #7
What does this PR change and why?
Checklist
/
/store
,/bag
,/log
,/settings
,/help
.Critical Changes
Related PRs
Testing
View page on root route
/