Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gsa/issue 54/update dropdown #689

Merged
merged 7 commits into from
Oct 25, 2024
Merged

Conversation

felder101
Copy link
Contributor

@felder101 felder101 commented Oct 25, 2024

Replaced USWDS select component with USWDS component for agency and bureau fields. Changes were made on loginless flow page, admin user edit, and generate training report.

@john-labbate
Copy link
Contributor

Sorry going to ask for a few additional things here.

  • Can you please move USWDSComboBox under the form-components folder and update any references to the new path.
  • We are missing test for that file as well. Its one of the components we inherited without them. Please take this opportunity to add at least a few basic ones into the system. See ValidatedMemorableDatepicker.spec.js for some quick ones you can copy and modify.

Otherwise it looks good.

@john-labbate john-labbate merged commit e497691 into staging Oct 25, 2024
5 checks passed
@felder101 felder101 deleted the GSA/issue-54/update-dropdown branch October 25, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants