Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1358 - Prototype sitemap.xml lastmod field #434

Merged
merged 1 commit into from
Feb 14, 2025
Merged

1358 - Prototype sitemap.xml lastmod field #434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions entities/core-result.entity.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,10 @@ export class CoreResult {
@Expose({ name: 'sitemap_xml_pdf_count' })
sitemapXmlPdfCount?: number;

@Column({ nullable: true })
@Exclude()
sitemapXmlLastMod?: string;

@Column({ nullable: true })
@Expose({ name: 'third_party_service_domains' })
@Transform(({ value }: { value: string }) => {
Expand Down
1 change: 1 addition & 0 deletions entities/scan-data.entity.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ export type SitemapXmlScan = {
sitemapXmlFinalUrlMimeType: string;
sitemapXmlStatusCode: number;
sitemapXmlDetected: boolean;
sitemapXmlLastMod?: string;
};

export type NotFoundScan = {
Expand Down
1 change: 1 addition & 0 deletions libs/core-scanner/src/pages/sitemap-xml.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ describe('sitemap-xml scanner', () => {
sitemapXmlFinalUrlLive: true,
sitemapTargetUrlRedirects: true,
sitemapXmlFinalUrlMimeType: 'text/xml',
sitemapXmlLastMod: null,
sitemapXmlStatusCode: 200,
sitemapXmlDetected: true,
},
Expand Down
7 changes: 7 additions & 0 deletions libs/core-scanner/src/pages/sitemap-xml.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,11 +61,18 @@ const buildSitemapResult = async (
sitemapXmlFinalUrlFilesize: Buffer.byteLength(sitemapText, 'utf-8'),
sitemapXmlCount: await getUrlCount(sitemapPage),
sitemapXmlPdfCount: getPdfCount(sitemapText),
sitemapXmlLastMod: getLastModDate(sitemapText),
}
: {}),
};
};

function getLastModDate(sitemapText: string) {
const re = /<lastmod>(.*?)<\/lastmod>/g;
const matches = [...sitemapText.matchAll(re)];
return matches.length > 0 ? matches[matches.length - 1][1] : null;
}

const getUrlCount = async (page: Page) => {
const urlCount = await page.evaluate(() => {
const urls = [...document.getElementsByTagName('url')];
Expand Down
2 changes: 2 additions & 0 deletions libs/database/src/core-results/core-result.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,7 @@ export class CoreResultService {
sitemap.sitemapXmlFinalUrlMimeType;
coreResult.sitemapXmlStatusCode = sitemap.sitemapXmlStatusCode;
coreResult.sitemapXmlDetected = sitemap.sitemapXmlDetected;
coreResult.sitemapXmlLastMod = sitemap.sitemapXmlLastMod;
} else {
logger.error({
msg: pages.sitemapXml.error,
Expand All @@ -295,6 +296,7 @@ export class CoreResultService {
coreResult.sitemapXmlFinalUrlMimeType = null;
coreResult.sitemapXmlStatusCode = null;
coreResult.sitemapXmlDetected = null;
coreResult.sitemapXmlLastMod = null;
}
}

Expand Down
Loading