Add Last-Modified header field

GSA · Jun 10, 2024 · 636a006 · 636a006
1 parent b50db5c
commit 636a006
Show file tree

Hide file tree

Showing 7 changed files with 27 additions and 1 deletion.
diff --git a/entities/core-result.entity.ts b/entities/core-result.entity.ts
@@ -457,6 +457,10 @@ export class CoreResult {
   })
   usaClassesUsed?: string;
 
+  @Column({ nullable: true })
+  @Exclude()
+  lastModifiedHeaderValue?: string;
+
   static getColumnNames(): string[] {
     // return class-transformer version of column names
     return Object.keys(classToPlain(new CoreResult()));

diff --git a/entities/scan-data.entity.ts b/entities/scan-data.entity.ts
@@ -35,6 +35,7 @@ export type SeoScan = {
   ogUrlContent: string;
   htmlLangContent: string;
   hrefLangContent: string;
+  lastModifiedHeaderValue: string;
 };
 
 export type ThirdPartyScan = {

diff --git a/libs/core-scanner/src/pages/primary.spec.ts b/libs/core-scanner/src/pages/primary.spec.ts
@@ -23,7 +23,7 @@ describe('primary scanner', () => {
       };
       const scanner = await createPrimaryScanner(mockLogger, input);
       const result = await scanner(page);
-      expect(result).toEqual({
+      expect(result).toMatchObject({
         urlScan: {
           targetUrlRedirects: true,
           finalUrl: 'https://18f.gsa.gov/',

diff --git a/libs/core-scanner/src/scans/seo.spec.ts b/libs/core-scanner/src/scans/seo.spec.ts
@@ -32,6 +32,7 @@ describe('seo scan', () => {
           'https://www.arc.gov/wp-content/uploads/2020/08/48982308566_5ce274f0ab_o-washington-scaled.jpg',
         ogTypeContent: 'website',
         ogUrlContent: 'https://www.arc.gov/',
+        lastModifiedHeaderValue: null,
       });
     }, 'arc_gov_dump.mht');
   });

diff --git a/libs/core-scanner/src/scans/seo.ts b/libs/core-scanner/src/scans/seo.ts
@@ -33,6 +33,7 @@ export const buildSeoResult = async (
   const ogUrlContent = await findOpenGraphTag(page, 'og:url');
   const htmlLangContent = await findHtmlLangContent(page);
   const hrefLangContent = await findHreflangContent(page);
+  const lastModifiedHeaderValue = await findLastModifiedHeaderValue(response);
 
   return {
     ogTitleFinalUrl,
@@ -49,6 +50,7 @@ export const buildSeoResult = async (
     ogUrlContent,
     htmlLangContent,
     hrefLangContent,
+    lastModifiedHeaderValue,
   };
 };
 
@@ -204,3 +206,17 @@ const findHreflangContent = async (page: Page): Promise<string> => {
 
   return content;
 };
+
+const findLastModifiedHeaderValue = async (
+  response: HTTPResponse,
+): Promise<string> => {
+  const headers = await response.headers();
+
+  for (const key in headers) {
+    if (key.toLowerCase() === 'last-modified') {
+      return headers[key];
+    }
+  }
+
+  return null;
+};
diff --git a/libs/database/src/core-results/core-result.service.spec.ts b/libs/database/src/core-results/core-result.service.spec.ts
@@ -119,6 +119,7 @@ describe('CoreResultService', () => {
             ogUrlContent: null,
             htmlLangContent: null,
             hrefLangContent: null,
+            lastModifiedHeaderValue: null,
           },
           thirdPartyScan: {
             thirdPartyServiceDomains: null,

diff --git a/libs/database/src/core-results/core-result.service.ts b/libs/database/src/core-results/core-result.service.ts
@@ -92,6 +92,8 @@ export class CoreResultService {
       coreResult.ogUrlContent = result.seoScan.ogUrlContent;
       coreResult.htmlLangContent = result.seoScan.htmlLangContent;
       coreResult.hrefLangContent = result.seoScan.hrefLangContent;
+      coreResult.lastModifiedHeaderValue =
+        result.seoScan.lastModifiedHeaderValue;
 
       // Third-party scan
       coreResult.thirdPartyServiceCount =
@@ -195,6 +197,7 @@ export class CoreResultService {
       coreResult.ogUrlContent = null;
       coreResult.htmlLangContent = null;
       coreResult.hrefLangContent = null;
+      coreResult.lastModifiedHeaderValue = null;
     }
   }