fixed bg-color for locked tag #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shayan-roshan
requested review from
davereed,
christyhermansen,
yerramshilpa and
cwolf10
as code owners
|
cwolf10
reviewed
Jan 30, 2025
| @@ -7,6 +7,8 @@ $error-lighter-alt: #FDB8AE; | |||
| $error-lightest-alt: #FDE0DB; | |||
| $error-dark-alt: #B50909; | |||
|
|
|||
| $base-lighter-alt: #E5E5E5; | |||
There was a problem hiding this comment.
I wouldn't have this as a var, and if you keep it as a var, I wouldn't call this base-lighter-alt.
I made the vars for the others because design was calling those colors "error-lightest" and wanted to keep straight that it's the "error-lightest" that they are asking for, but an alt to the error-lightest we have in the code.
For this background they just gave a hex code, and the code is not used anywhere else, I think you're fine to just use the hex code in L461.
There was a problem hiding this comment.
removed the base-lighter alt var and used the hex instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed bg color for locked status tag from #c9c9c9 to #e5e5e5.