Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added top border for first child of side-nav item #728

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

shayan-roshan
Copy link
Contributor

resolves #726

added top border for the first element of side nav item.
Screen Shot 2025-01-30 at 8 40 59 AM

Copy link

github-actions bot commented Jan 30, 2025

PR Preview Action v1.6.0
Preview removed because the pull request was closed.
2025-01-30 20:39 UTC

@include u-border-top('1px');
}

&:not(:first-child) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems odd that you're only including just the first on line 70, but then having to ignoring the rest. Are you sure the :first-child is applying only to the first?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nevermind, it's a uswds style that is blanket adding border-top. So yeah you'd have to undo that for every other item.

Copy link
Contributor

@cwolf10 cwolf10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shayan-roshan shayan-roshan merged commit 99afc99 into master Jan 30, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Top border styling issue with usa-sidenav
2 participants