Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a command to see a service's sms sender phone numbers #1545

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

terrazoon
Copy link
Contributor

@terrazoon terrazoon commented Jan 29, 2025

Description

As we continue to investigate the 'wrong sender phone number' issue, add a command so we can inspect the values in the service_sms_senders table in the database.

Security Considerations

  • The numbers being retrieved are public numbers, as they are the ones that the messages come from.
  • This command can only be run on machines by folks who have access to the information (or locally for development purposes, with test data), and/or in the environment in which the app itself runs.

@terrazoon terrazoon self-assigned this Jan 29, 2025
@terrazoon terrazoon linked an issue Jan 29, 2025 that may be closed by this pull request
Copy link
Contributor

@ccostino ccostino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @terrazoon! I see the parametrized query being used, thank you. 🙂

I added a couple of security considerations to the PR description; good to go!

@ccostino ccostino merged commit 50d8bef into main Feb 3, 2025
7 checks passed
@ccostino ccostino deleted the notify-api-1544 branch February 3, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make a command to see sender phone numbers for each service
3 participants