fix more sqlalchemy #1417
Merged
fix more sqlalchemy #1417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 14, 2024 11:26
xlorepdarkhelm
approved these changes
Nov 15, 2024
added 2 commits
January 7, 2025 07:10
|
Looks like this PR needs another quick sync with |
ccostino
reviewed
Jan 21, 2025
There was a problem hiding this comment.
Thanks a ton for all of this, @terrazoon!
I only had two remaining questions to check on quick. Thanks for calling out the pagination within the tests, too. As long as those results are working as expected I think that's okay for now and we can clean that up more afterward.
xlorepdarkhelm
approved these changes
Jan 21, 2025
ccostino
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix remaining queries affected by the upgrade to sqlalchemy 2.0
NOTE: To find things that need changing the search is
grep -ri "query\." ./**/**.py. In order to make search either, occurrences where 'query' was just being used as a variable name were changed to 'querie'.NOTE: There is one test in notification_dao where I changed the expected result. I think sqlalchemy broke whatever strange thing that test was trying to do. As a matter of good maintenance, I don't think the test is doing the right thing trying to override the behavior of the Pagination object based on a flag.
Security Considerations
N/A